Add issue approver output and enhance approval logic#206
Add issue approver output and enhance approval logic#206felpasl wants to merge 1 commit intotrstringer:mainfrom
Conversation
- Updated action outputs to include the GitHub username of the approver. - Modified approval logic to return the approver's username upon approval or denial. - Enhanced tests to validate the new approver output. Rename 'issue-approver' to 'issue-responder' for clarity in approval process
felpasl
force-pushed
the
feat/190-add-approver-output
branch
from
e4012c2 to
bac46d0
Compare
|
@lizziemac If possible, please review these changes; otherwise, I may publish the fork for my own use. thanks. |
Hi @felpasl Thanks a lot for this contribution. I understand that it has been very long, and you might have deployed your fork. The code changes look good to me. For good measure, is it possible to share some test results to show no breaking change for users operating with the previous version of inputs, and one test with your change? |
| test: | ||
| go test -v . | ||
|
|
||
| .PHONY: test_docker |
There was a problem hiding this comment.
What is the purpose of this test_docker make target?
lizziemac
added
the
Changes Requested
| @@ -1,5 +1,6 @@ | |||
| IMAGE_REPO=ghcr.io/trstringer/manual-approval | |||
| TARGET_PLATFORM=linux/amd64,linux/arm64,linux/arm/v8 | |||
| GO_DOCKER_IMAGE=golang:1.24 | |||
There was a problem hiding this comment.
let's make a separate PR for this - ideally this image should match what is built & deployed
There was a problem hiding this comment.
and I'd like to add this to the readme, potentially even replace the current 'test' command
|
@felpasl Apologies for how long the back and forth is here, I wasn't getting emails for direct @'s. I can approve this once the test_docker target is separated out |
3 participants
related to #190