lean: Remove Nat.cast from Fin, in preparation for a Lean upgrade - #303
Merged
Conversation
The new behavior can be emulated with `attribute [-instance] Fin.instCommRing Fin.instNatCast Fin.instAddMonoidWithOne`. While the old behavior can be kept with `open scoped Fin.CommRing`, the spelling without is usually clearer anyway.
eric-wieser
changed the title
Nat.cast from Fin, in preparation for a Lean upgradeNat.cast from Fin, in preparation for a Lean upgrade
GeorgeTsoukalas
approved these changes
Aug 28, 2025
GeorgeTsoukalas
left a comment
GeorgeTsoukalas
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, thanks Eric!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new behavior can be emulated with
attribute [-instance] Fin.instCommRing Fin.instNatCast Fin.instAddMonoidWithOne.While the old behavior can be kept with
open scoped Fin.CommRing, the spelling without is usually clearer anyway.