Reformat source code for consistent style #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koszti
force-pushed
the
code-format
branch
4 times, most recently
from
b8e7c99 to
3c13302
Compare
mosabua
approved these changes
May 4, 2025
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Looks good. Please update the commit message to something like
Reformat source code for consistent style
* Enable eslint and prettier config for validation during build
* No functional code changes, source code format only
Also maybe add info about this command to the readme file so developers know without looking at gha definition.
Member
|
Thoughts @nineinchnick @wendigo @georgewfisher ? |
nineinchnick
approved these changes
May 4, 2025
koszti
changed the title
wendigo
approved these changes
May 4, 2025
wendigo
left a comment
wendigo
left a comment
There was a problem hiding this comment.
I've reviewed configuration for prettier + workflow + ignore files.
I'd extract the automatic changes to a separate commit.
* Enable eslint and prettier config for validation during build * No functional code changes, source code format only
Member
Author
Member
|
Looks good to me. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces standardized code formatting by adding
.prettierrcand.eslintrc.cjsfiles, using the same style rules and npm targets (such ascheck,lint) as the main Trino Preview UI codebase. This ensures consistent code style across both codebases.Additional context and related issues
All existing files have been reformatted to align with the new style rules. This PR contains only formatting changes and no new functionality or behavioral changes are introduced.