Zdict general cleanup #236
Conversation
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Patch coverage is low due to many small changes in error handling and debug logs |
folkertdev
left a comment
folkertdev
left a comment
There was a problem hiding this comment.
Some nits, looks good overall
| c = b'.'; | ||
|
|
||
| /// Prints the bytes as characters, with non-printable characters replaced by '.' | ||
| fn ZDICT_printHex(bytes: &[u8]) { |
There was a problem hiding this comment.
can you leave a note here that this is only used for debug output? The implementation locks and releases stderr for every character: we could do that more efficiently but I don't think we should bother.
There was a problem hiding this comment.
I couldn't help it to improve it anyway, now it's just a single eprint! :)
| return Error::dictionaryCreation_failed.to_error_code(); | ||
| } | ||
| ZDICT_initDictItem(dictList); | ||
| dictList.as_mut().unwrap().init(); |
There was a problem hiding this comment.
this probably gets cleaned up; the init function then won't even be needed
This makes sure the bounds are checked
michielp1807
force-pushed
the
zdict-cleanup
branch
from
0066aa3 to
e0b2b7f
Compare
No description provided.