Skip to content

Fix iterating over keys when changelog topic is set. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aoberegg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix iterating over keys when changelog topic is set. #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56ee814
adjusted changelog topic name as proposed in slack channel
Oct 8, 2020
6ca7efe
Merge pull request #1 from aoberegg/changelog_topic_naming
aoberegg Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion faust/stores/rocksdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ def _dbs_for_key(self, key: bytes) -> Iterable[DB]:

def _dbs_for_actives(self) -> Iterator[DB]:
actives = self.app.assignor.assigned_actives()
topic = self.table._changelog_topic_name()
topic = self.table.changelog_topic_name
for partition, db in self._dbs.items():
tp = TP(topic=topic, partition=partition)
if tp in actives:
Expand Down