[Awaiter] Fix bug with context cancellation spreading to other processes#885
Merged
mhutchinson merged 4 commits intotransparency-dev:mainfrom Mar 5, 2026
Merged
Conversation
Issue: The publication awaiter had some curious logic that set any context error received by any of the routines awaiting it onto the core error shared by all blocked routines. This meant that the timeout of any goroutine poisoned all other routines that happened to be waiting at the same time. Impact: This would not be noticed on services where the deadline was not being reached. However, for services where the deadline was reached, potentially successful calls to the awaiter would be terminated early with `context.deadlineExceededError`. This is likely to lead to a higher number of failing calls than expected.
AlCutter
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: The publication awaiter had some curious logic that set any context error received by any of the routines awaiting it onto the core error shared by all blocked routines. This meant that the timeout of any goroutine poisoned all other routines that happened to be waiting at the same time.
Impact: This would not be noticed on services where the deadline was not being reached. However, for services where the deadline was reached, potentially successful calls to the awaiter would be terminated early with
context.deadlineExceededError. This is likely to lead to a higher number of failing calls than expected.