Skip to content

Add tracing to witnessing #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlCutter merged 1 commit into from
Mar 4, 2026
Merged

Add tracing to witnessing #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions append_lifecycle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,8 +647,10 @@ func (o AppendOptions) CheckpointPublisher(lr LogReader, httpClient *http.Client
if err != nil {
return nil, fmt.Errorf("newCP: %v", err)
}
span.AddEvent("Created CP")
appenderSignedSize.Record(ctx, otel.Clamp64(size))

span.AddEvent("Starting witnessing")
// Handle witnessing
{
// Figure out the likely size the witnesses are aware of, but don't fail hard if we're unable
Expand All @@ -672,6 +674,7 @@ func (o AppendOptions) CheckpointPublisher(lr LogReader, httpClient *http.Client
ctx, cancel := context.WithTimeout(ctx, o.witnessOpts.Timeout)
defer cancel()

span.AddEvent("Sending witness requests")
witAttr := []attribute.KeyValue{}
cp, err = wg.Witness(ctx, cp)
if err != nil {
Expand Down
3 changes: 2 additions & 1 deletion internal/witness/otel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ import (
const name = "github.com/transparency-dev/tessera/internal/witness"

var (
meter = otel.Meter(name)
tracer = otel.Tracer(name)
meter = otel.Meter(name)
)

var (
Expand Down
Loading
Loading