-
Notifications
You must be signed in to change notification settings - Fork 42
[GCP] Structured logging for GCP-only files #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mhutchinson
wants to merge
6
commits into
transparency-dev:main
Choose a base branch
from
mhutchinson:slogging-away
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5396a7c
[GCP] Exploration into using structured logging
mhutchinson 2e5bc92
Change implicit key-values to explicit typed ones
mhutchinson 5ac047a
Lint usage of slog
mhutchinson f5da216
Default GCP project
mhutchinson e3c4e46
Don't read the GCP project name from env
mhutchinson 1293420
Top levels docs
mhutchinson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| // Copyright 2026 The Tessera authors. All Rights Reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Package logger provides structured logging utilities. | ||
| package logger | ||
|
|
||
| import ( | ||
| "context" | ||
| "log/slog" | ||
|
|
||
| "go.opentelemetry.io/otel/trace" | ||
| ) | ||
|
|
||
| // GCPContextHandler is an slog.Handler that extracts OpenTelemetry tracing | ||
| // information from the context and adds it to the log record in the format | ||
| // expected by GCP Cloud Logging, allowing logs to be correlated with traces. | ||
| type GCPContextHandler struct { | ||
| slog.Handler | ||
| projectID string | ||
| } | ||
|
|
||
| // NewGCPContextHandler wraps the provided slog.Handler. It injects GCP Cloud Logging | ||
| // compatible trace fields extracted from the context if a valid span is present. | ||
| func NewGCPContextHandler(h slog.Handler, projectID string) *GCPContextHandler { | ||
| return &GCPContextHandler{Handler: h, projectID: projectID} | ||
| } | ||
|
|
||
| // Handle adds the trace ID, span ID, and sampled flag to the record attributes. | ||
| func (h *GCPContextHandler) Handle(ctx context.Context, r slog.Record) error { | ||
| span := trace.SpanContextFromContext(ctx) | ||
| if span.IsValid() { | ||
| // GCP Cloud Logging expects the trace ID to be formatted as: | ||
| // projects/[PROJECT_ID]/traces/[TRACE_ID] | ||
| // https://docs.cloud.google.com/logging/docs/structured-logging#structured_logging_special_fields | ||
| tracePath := span.TraceID().String() | ||
| if h.projectID != "" { | ||
| tracePath = "projects/" + h.projectID + "/traces/" + tracePath | ||
| } | ||
|
|
||
| r.AddAttrs( | ||
| slog.String("logging.googleapis.com/trace", tracePath), | ||
| slog.String("logging.googleapis.com/spanId", span.SpanID().String()), | ||
| slog.Bool("logging.googleapis.com/trace_sampled", span.IsSampled()), | ||
| ) | ||
| } | ||
| return h.Handler.Handle(ctx, r) | ||
| } | ||
|
|
||
| // WithAttrs returns a new handler with the given attributes, preserving the GCP handling. | ||
| func (h *GCPContextHandler) WithAttrs(attrs []slog.Attr) slog.Handler { | ||
| return &GCPContextHandler{Handler: h.Handler.WithAttrs(attrs), projectID: h.projectID} | ||
| } | ||
|
|
||
| // WithGroup returns a new handler with the given group name, preserving the GCP handling. | ||
| func (h *GCPContextHandler) WithGroup(name string) slog.Handler { | ||
| return &GCPContextHandler{Handler: h.Handler.WithGroup(name), projectID: h.projectID} | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth having a package per infra - I'm not entirely sure whether the go linker will be able to ditch all the unneeded stuff if it's all in the same package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered that but figured we could do it later if needed as its all internal. This thing doesn't have any big deps other than some strings, so I figured this is safe. Am I underestimating some hidden cost?