Add logs for mountpoint and s3fs #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadmobile
reviewed
Oct 20, 2025
| # mount-s3 command for Linux | ||
| cmd = ["mount-s3", "--profile", profile, bucket_name, remote_workspace_dir, "--allow-overwrite", "--allow-delete"] | ||
|
|
||
| cmd = [ |
There was a problem hiding this comment.
Any potential performance hit here or anything? Just wondering if we want to be able to disable in prod or do you think it'll be extra desireable in prod? :)
There was a problem hiding this comment.
yes this should be for dev only
There was a problem hiding this comment.
Added a debug mode and added for s3fs
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
aliasaria
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on transformerlab/transformerlab-sdk#43