[TF24 hydraulics] Refresh pre-PM baselines: re-bless scenario gateway + regenerable reference run - #568
Merged
Merged
Conversation
…develop The recorded gateway baseline was stamped at 5879d73 (package 2.0.0.9001) and had drifted: 5 scenarios that it recorded as `failure` now persist, from work merged since (NSC storage #517/#554, layered soil #558). The drift is unrelated to any one change and left the opt-in gateway test (PLANT_RUN_SCENARIOS=1) red. Regenerated on develop @ 141dc8d via `make bless-scenarios` (mpl=100). This records the current observed outcomes as the reference so the gateway diff is meaningful again. NOTE: the scenarios' a-priori `expected` column (from inst/scenarios/) still encodes the old expectations, so match_rate is 0.375 — maintainers may want to revisit those expectations separately. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Replaces the former hand-saved results_high.RDS, which predated the pars refactor (#410) and could no longer be loaded/replayed against the current model. That file was gitignored (never a committed artifact), so the reproducible deliverable is the generator: a canonical single-species TF24 SCM run (fixed traits + env, fast default Control, mpl=50) that anyone can regenerate locally with `Rscript scripts/generate_reference_run.R`. The output round-trips against the current code (unlike the stale file). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Housekeeping companion to #567 (Penman-Monteith), kept separate so the baseline
refresh is not attributed to PM (PM is off / bit-identical here).
Re-bless
scenario_baseline.rds. The recorded gateway baseline was stampedat
5879d73(pkg 2.0.0.9001) and had drifted: 5 scenarios it recorded asfailurenow persist, from work merged since (NSC storage [TF24 nsc] Enable resource storage, presumably NSCs, to buffer short-term variation in productivity #517/NSC storage pool for TF24 with reserve-gated growth (#517) #554,layered soil feat(tf24): add layered soil parameter API with strict depth validation #558). That left the opt-in gateway test (
PLANT_RUN_SCENARIOS=1)red for reasons unrelated to any one change. Regenerated on
developviamake bless-scenarios(mpl=100) so the diff is meaningful again.Note for reviewers: the scenarios' a-priori
expectedcolumn (frominst/scenarios/) still encodes the old expectations, somatch_rateis now0.375 — worth revisiting those expectations separately.
Add
scripts/generate_reference_run.R. Replaces the former hand-savedresults_high.RDS, which predated theparsrefactor ([simplify interface] Clarify use of expand_parameters, strategy_list, hyperpar #410), could no longerbe loaded/replayed, and was in fact gitignored (never a committed artifact).
The reproducible deliverable is the generator: a canonical single-species TF24
SCM run whose output round-trips against the current model.
🤖 Generated with Claude Code