Synonyms for accepted names - #270
Merged
Merged
Conversation
Per user request, a function that summarises all past names by which a currently accepted taxon has been referred to. While other APCalign functions are excellent for updating names, they aren't designed to take a currently accepted name and work backwards - for instance, if you want to know what names to search up in the literature to find information about a species that has changed names. This function is in the testing stage - the exact output format and parameters have not been finalised.
- added tests - added documentation - added parameter that lets you collapse by accepted species or return one row per synonym
ehwenk
requested review from
dfalster and
wcornwell
and removed request for
dfalster
March 23, 2026 05:05
dfalster
previously approved these changes
Mar 23, 2026
dfalster
left a comment
dfalster
left a comment
Member
There was a problem hiding this comment.
Nice work. I made some edits to make it consistent with other functions and help pass tests.
I suggest expanding the test group of names! We could probably generate some automatically from the resources if that helps
dfalster
self-requested a review
March 24, 2026 06:01
dfalster
approved these changes
Mar 24, 2026
dfalster
left a comment
dfalster
left a comment
Member
There was a problem hiding this comment.
Nice work! Added some small changes to work with recent changes on master
Feel free to merge once tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition of a new function that indicates synonyms for a currently accepted name, outputting results in either a long format (each synonym as its own row) or as a collapsed form, with all synonyms for a currently accepted name collapsed into a single cell.
Synonyms are sorted by "type" in the same priority order specified in
align_taxa, the synonym -> accepted updating function.This function should be very useful if you have the current name of a taxon and want to work backwards and search the literature for references to the same taxon concept.