Update functions to include infrataxa - #268
Merged
Merged
Conversation
Per request of several users, update `create_species_state_origin_matrix` and `native_anywhere_in_australia` to include a parameter that includes infrataxa. Right now the original "species only" variant of the function is the default, but maybe the parameter `include_infrataxa` should instead default to TRUE. Also, these two functions label the column with taxon names as "species". Would it be better to use either "taxon_name" or "accepted_name"?
remove `(` at start of genus names. Relevant for some hybrids of hybrid names
- added tests - updated documentation - additional small changes
Contributor
|
i think i can fix this one, should i try? |
Member
|
Go for it @wcornwell ! |
Member
|
There's another PR about to merged into master so perhaps wait until that has been merged in before updating this branch from master |
The state diversity benchmarks now pass locally.
dfalster
self-requested a review
March 24, 2026 08:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
familyandtaxon_idtocreated_species_state_origin_matrix