Add missing BrainPool and Curve25519 algorithms#2897
Open
Hinara wants to merge 1 commit intotpm2-software:masterfrom
Open
Add missing BrainPool and Curve25519 algorithms#2897Hinara wants to merge 1 commit intotpm2-software:masterfrom
Hinara wants to merge 1 commit intotpm2-software:masterfrom
Conversation
Signed-off-by: Milas Robin <milas.robin@live.fr>
Hinara
force-pushed
the
add-ecc-algorithm
branch
from
4702fda to
2256608
Compare
Member
|
I don't want to merge code without a test. Does swtpm/libtpms support these curves by now ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add support to BrainPool and Curve25519 algorithms.
Only Brainpool seems to have direct ECC support in OpenSSL.
Support for Curve25519 in OpenSSL exist but under the algorithms X25519 and ED25519.