For #305 - Add support for Compose multiplatform #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OS app This will ensure the iOS app can be built.
This will allow to share it with iOS also. Migrated to Material3 and Dynamic Color support for Android in the meantime. Migrated to support automatic day/night theme support for both platforms.
…red on Android Added moko-resources as the community preferred approach to using strings in similar scenarios. Added the materialIconsExtended dependency for :shared instead of reusing the vector images shown previously from :app since those vectors are not in a format moko-resources supports at this moment (though it support SVGs). While this is a big package R8 will ensure unused resources are stripped from the generated builds at compile time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Compose Multiplatform - https://blog.jetbrains.com/kotlin/2023/05/compose-multiplatform-for-ios-is-in-alpha/
More details available in the individual commit's message.
The gist of changes is that all the UI is now moved from :app to :shared and with the help of Compose Multiplatform both Android and iOS apps will share not just the same functionality but also the same UI.
For maintainers: I think this can be a separate branch in the project. I can ask merging in a new more suitable branch if one is created for this.
KaMPKit.-.Compose.Multiplatform.on.Android.mp4
kampkit-compose-multiplatform-on-ios_WMRq8CUN.mp4