fix(timing feedback by Albert): general fixes and improvements#87
Open
AlberttFrgk wants to merge 13 commits into
Open
fix(timing feedback by Albert): general fixes and improvements#87AlberttFrgk wants to merge 13 commits into
AlberttFrgk wants to merge 13 commits into
Conversation
better accuracy and new preview demo
GabuTheDev
approved these changes
May 9, 2026
GabuTheDev
changed the title
last commit
Contributor
Author
|
never mind i have 1 more to commit |
got feedback for this issue
…bility stupid bug
AlberttFrgk
commented
May 9, 2026
| } | ||
|
|
||
| if (data.hitErrors.length > processedHits) { | ||
| for (let i = processedHits; i < data.hitErrors.length; i++) { |
Contributor
Author
There was a problem hiding this comment.
this causing issue, i revert back and better approach on newer code
pls god no more bug
seems issue i talk it because custom image
AlberttFrgk
changed the title
Contributor
Author
fixed this issue after brainstroming |
Contributor
Author
after fix
|
GabuTheDev
changed the title
GabuTheDev
approved these changes
May 9, 2026
|
|
||
| applyFontSettings(); | ||
|
|
||
| // THE FIX: Preload both images immediately so they never have to decode mid-game |
Member
There was a problem hiding this comment.
you really don't have to add comments like this.
| uiText.classList.add("hide-visual"); | ||
| uiImage.classList.remove("hide-visual"); | ||
| uiImage.src = isEarly ? settings.imageEarly : settings.imageLate; | ||
| // INSTANT TOGGLE: We just flip the visibility. The images are already loaded in the DOM. |
Contributor
Author
There was a problem hiding this comment.
yep i tired to fix it yesterday i use ai this time i can remove it if u want
Contributor
Author
|
no update until peppy did something |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
better accuracy and new preview demo
