feat: amend login params for audit#472
Merged
chaitanyapotti merged 5 commits intomasterfrom Mar 31, 2026
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
chaitanyapotti
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Jira Link
https://consensyssoftware.atlassian.net/browse/EMBED-226
Description
oauthInitiatedandoauthFailedin the login flow.recordIdis persisted intoargs.customStatebefore session creation, preventing a secondrecordIdfrom being generated aftergetRedirectResult().recordIdandauthConnectionthrough to Torus key retrieval so the same audit context is preserved through completion.callCitadelAuditApi()helper to send audit events to the Citadel endpoint.recordIdreuse.How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Note
Medium Risk
Changes the login flow’s error propagation and extends Torus share retrieval inputs (
recordId,authConnection), which could affect redirect/popup login behavior and downstream consumers relying on previous error types/messages.Overview
Improves the login flow by catching failures during redirect/popup handling in
triggerLoginand rethrowing them as a dedicatedCustomAuthLoginErrorwith a stableCustomAuthLoginErrorPrefix.Extends Torus key retrieval by passing through additional audit context (
recordIdfromcustomStateand the resolvedauthConnection) intoretrieveShares, and bumps@toruslabs/torus.jsto^17.2.3. Adds unit tests covering the new error type/prefix and the wrapped-error behavior, plus minor repo hygiene updates (.gitignoreadds.npmrc).Written by Cursor Bugbot for commit bfb9f26. This will update automatically on new commits. Configure here.