refactor(http-protocol): decouple from udp-protocol#1839
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the udp-protocol dependency edge from the HTTP protocol crate, keeping HTTP announce event mappings anchored on torrust-tracker-primitives::AnnounceEvent, and updates EPIC/issue tracking docs to mark SI-13 as complete.
Changes:
- Removed
torrust-tracker-udp-tracker-protocolfromtorrust-tracker-http-tracker-protocoldependencies. - Removed the HTTP
Eventconversion impl fromtorrust_tracker_udp_tracker_protocol::AnnounceEvent. - Updated SI-13 issue spec and EPIC tracking to reflect completion and updated dependency narrative.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/http-protocol/src/v1/requests/announce.rs | Removes UDP→HTTP event conversion, leaving only primitives-based conversions. |
| packages/http-protocol/Cargo.toml | Drops the torrust-tracker-udp-tracker-protocol dependency from the HTTP protocol crate. |
| docs/issues/open/1834-1669-13-decouple-http-protocol-from-udp-protocol.md | Marks tasks/acceptance criteria/verification as DONE with evidence notes. |
| docs/issues/open/1669-overhaul-packages/EPIC.md | Updates dependency narrative and marks SI-13 as completed in EPIC tracking. |
| Cargo.lock | Removes the transitive lock entry for the dropped dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| `torrust-http-tracker-protocol` currently depends on | ||
| `torrust-tracker-primitives` and `torrust-udp-tracker-protocol`. The move can be | ||
| `torrust-tracker-primitives`. The move can be |
There was a problem hiding this comment.
Fixed in 1657e6e. The EPIC now consistently refers to torrust-tracker-http-tracker-protocol.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1839 +/- ##
===========================================
+ Coverage 77.80% 77.83% +0.02%
===========================================
Files 380 380
Lines 28592 28585 -7
Branches 28592 28585 -7
===========================================
+ Hits 22247 22249 +2
+ Misses 6033 6023 -10
- Partials 312 313 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
ACK 1657e6e |
Summary
torrust-tracker-udp-tracker-protocoldependency frompackages/http-protocolFrom<torrust_tracker_udp_tracker_protocol::AnnounceEvent> for Eventfrom HTTP announce request parsingtorrust-tracker-primitives::AnnounceEventVerification
Issue
http-protocolfromudp-protocol#1834