feat(PM-578): Apply for copilot opportunity #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const [notes, setNotes] = useState('') | ||
| const [success, setSuccess] = useState(false); | ||
|
|
||
| const onApply = useCallback(async () => { |
There was a problem hiding this comment.
Consider adding error handling for the applyCopilotOpportunity function call to manage any potential failures or exceptions that might occur during the API request.
There was a problem hiding this comment.
@hentrymartin please wrap the applyCopilotOpportunity in try/catch block to avoid calling props.onApplied() & setSuccess(true) if the API call fails for some reason.
...lots/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx
Show resolved
Hide resolved
...lots/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx
Outdated
Show resolved
Hide resolved
...ps/copilots/src/pages/copilot-opportunity-details/apply-opportunity-modal/styles.module.scss
Show resolved
Hide resolved
src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx
Outdated
Show resolved
Hide resolved
src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx
Outdated
Show resolved
Hide resolved
src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx
Outdated
Show resolved
Hide resolved
src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx
Outdated
Show resolved
Hide resolved
src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx
Outdated
Show resolved
Hide resolved
...lots/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx
Show resolved
Hide resolved
...lots/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx
Outdated
Show resolved
Hide resolved
...lots/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx
Show resolved
Hide resolved
...lots/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx
Show resolved
Hide resolved
...lots/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx
Show resolved
Hide resolved
src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx
Outdated
Show resolved
Hide resolved
src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx
Outdated
Show resolved
Hide resolved
...lots/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx
Outdated
Show resolved
Hide resolved
...lots/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx
Show resolved
Hide resolved
kkartunov
requested changes
May 7, 2025
| const [notes, setNotes] = useState('') | ||
| const [success, setSuccess] = useState(false); | ||
|
|
||
| const onApply = useCallback(async () => { |
There was a problem hiding this comment.
@hentrymartin please wrap the applyCopilotOpportunity in try/catch block to avoid calling props.onApplied() & setSuccess(true) if the API call fails for some reason.
...lots/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx
Outdated
Show resolved
Hide resolved
src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx
Outdated
Show resolved
Hide resolved
src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx
Outdated
Show resolved
Hide resolved
...lots/src/pages/copilot-opportunity-details/apply-opportunity-modal/ApplyOpportunityModal.tsx
Show resolved
Hide resolved
|
@kkartunov I've updated the PR based on your comments, can you please have a look on it again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-578
What's in this PR?