Tweaks for showing specific details to mixed roles

Author: jmgasper

src/apps/review/src/lib/components/common/TableColumnRenderers.tsx

@@ -242,8 +242,11 @@ export function renderReviewScoreCell(
                 .trim()
                 .toUpperCase()
             : ''
+        const hasValidScore = typeof review.finalScore === 'number'
+            && Number.isFinite(review.finalScore)
+
         if (!normalizedStatus) {
-            return true
+            return !hasValidScore
         }
 
         return normalizedStatus !== 'COMPLETED'
@@ -540,9 +543,9 @@ export function renderScoreCell(
     }
 
     const reviewInfo = reviewDetail.reviewInfo
-    const reviewId = reviewInfo?.id || reviewDetail.reviewId
+    const reviewId = reviewInfo?.id ?? reviewDetail.reviewId
 
-    if (!reviewInfo || !reviewId) {
+    if (!reviewId) {
         return (
             <span className={styles.notReviewed}>
                 --

src/apps/review/src/lib/models/ReviewResult.model.ts

@@ -11,6 +11,7 @@ import { BackendReview } from './BackendReview.model'
  * Review result info
  */
 export interface ReviewResult {
+    id?: string
     appeals: AppealResult[]
     createdAt: string | Date
     createdAtString?: string // this field is calculated at frontend
@@ -111,6 +112,7 @@ export function convertBackendReviewToReviewResult(
         appeals: [],
         createdAt,
         createdAtString,
+        id: data.id,
         phaseName,
         resourceId: data.resourceId,
         reviewDate,

src/apps/review/src/lib/models/SubmissionInfo.model.ts

@@ -22,6 +22,7 @@ export interface SubmissionInfo {
     memberId: string
     userInfo?: BackendResource // this field is calculated at frontend
     review?: ReviewInfo
+    reviewInfos?: ReviewInfo[]
     reviews?: ReviewResult[]
     /**
      * Backend review type identifier (e.g. 'Post-Mortem Review').
@@ -109,6 +110,9 @@ export function convertBackendSubmissionToSubmissionInfo(
         ? isPassingReviewRaw
         : undefined
     const reviewEntries = Array.isArray(data.review) ? data.review : []
+    const reviewInfos = reviewEntries.map(convertBackendReviewToReviewInfo)
+    const reviewResults = reviewEntries.map(convertBackendReviewToReviewResult)
+    const primaryReviewInfo = reviewInfos[0]
     const primaryReview = reviewEntries[0]
 
     return {
@@ -117,11 +121,9 @@ export function convertBackendSubmissionToSubmissionInfo(
         isLatest: data.isLatest,
         isPassingReview,
         memberId: data.memberId,
-        review:
-            primaryReview
-                ? convertBackendReviewToReviewInfo(primaryReview)
-                : undefined,
-        reviews: reviewEntries.map(convertBackendReviewToReviewResult),
+        review: primaryReviewInfo,
+        reviewInfos,
+        reviews: reviewResults,
         reviewTypeId: primaryReview?.typeId ?? undefined,
         submittedDate,
         submittedDateString,