Skip to content

Commit 0d1ef7c

Browse files
committed
Fix for screening button not showing
1 parent 78fb03d commit 0d1ef7c

File tree

7 files changed

+500
-142
lines changed

7 files changed

+500
-142
lines changed

src/apps/review/src/lib/components/TableCheckpointSubmissions/TableCheckpointSubmissions.module.scss

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,16 @@
114114
}
115115
}
116116

117+
.pendingScore {
118+
color: var(--GrayFontColor);
119+
120+
&:hover,
121+
&:focus {
122+
color: $blue-120;
123+
text-decoration: underline;
124+
}
125+
}
126+
117127
// Action column styles (mirrors TableIterativeReview)
118128
.submit {
119129
align-items: center;

src/apps/review/src/lib/components/TableCheckpointSubmissions/TableCheckpointSubmissions.tsx

Lines changed: 27 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -350,20 +350,24 @@ export const TableCheckpointSubmissions: FC<Props> = (props: Props) => {
350350
label: 'Screening Score',
351351
propertyName: 'score',
352352
renderer: (data: Screening) => {
353-
const hasNumericScore = data.score && data.score !== 'Pending'
354353
const reviewId = data.reviewId
355-
const canViewScorecard = hasNumericScore && reviewId
354+
const scoreLabel = data.score ?? 'Pending'
356355

357-
if (!canViewScorecard) {
358-
return <span>{data.score}</span>
356+
if (!reviewId) {
357+
return <span>{scoreLabel}</span>
359358
}
360359

361360
return (
362361
<Link
363362
to={`./../review/${reviewId}`}
364-
className={styles.scoreLink}
363+
className={classNames(
364+
styles.scoreLink,
365+
{
366+
[styles.pendingScore]: !data.score || data.score === 'Pending',
367+
},
368+
)}
365369
>
366-
{data.score}
370+
{scoreLabel}
367371
</Link>
368372
)
369373
},
@@ -508,20 +512,24 @@ export const TableCheckpointSubmissions: FC<Props> = (props: Props) => {
508512
label: 'Review Score',
509513
propertyName: 'score',
510514
renderer: (data: Screening) => {
511-
const hasNumericScore = data.score && data.score !== 'Pending'
512515
const reviewId = data.reviewId
513-
const canViewScorecard = hasNumericScore && reviewId
516+
const scoreLabel = data.score ?? 'Pending'
514517

515-
if (!canViewScorecard) {
516-
return <span>{data.score}</span>
518+
if (!reviewId) {
519+
return <span>{scoreLabel}</span>
517520
}
518521

519522
return (
520523
<Link
521524
to={`./../review/${reviewId}`}
522-
className={styles.scoreLink}
525+
className={classNames(
526+
styles.scoreLink,
527+
{
528+
[styles.pendingScore]: !data.score || data.score === 'Pending',
529+
},
530+
)}
523531
>
524-
{data.score}
532+
{scoreLabel}
525533
</Link>
526534
)
527535
},
@@ -530,30 +538,30 @@ export const TableCheckpointSubmissions: FC<Props> = (props: Props) => {
530538
{
531539
label: 'Checkpoint Reviewer',
532540
propertyName: 'checkpointReviewer',
533-
renderer: (data: Screening) => (data.screener?.id ? (
541+
renderer: (data: Screening) => (data.checkpointReviewer?.id ? (
534542
<a
535-
href={getHandleUrl(data.screener)}
543+
href={getHandleUrl(data.checkpointReviewer)}
536544
target='_blank'
537545
rel='noreferrer'
538546
style={{
539-
color: data.screener?.handleColor,
547+
color: data.checkpointReviewer?.handleColor,
540548
}}
541549
onClick={function onClick() {
542550
window.open(
543-
getHandleUrl(data.screener),
551+
getHandleUrl(data.checkpointReviewer),
544552
'_blank',
545553
)
546554
}}
547555
>
548-
{data.screener?.memberHandle ?? ''}
556+
{data.checkpointReviewer?.memberHandle ?? ''}
549557
</a>
550558
) : (
551559
<span
552560
style={{
553-
color: data.screener?.handleColor,
561+
color: data.checkpointReviewer?.handleColor,
554562
}}
555563
>
556-
{data.screener?.memberHandle ?? ''}
564+
{data.checkpointReviewer?.memberHandle ?? ''}
557565
</span>
558566
)),
559567
type: 'element',

0 commit comments

Comments
 (0)