-
Notifications
You must be signed in to change notification settings - Fork 17
Add decodeToMap method to directly parse a string into a Map<String, Object> #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Asintotoo
wants to merge
10
commits into
toon-format:main
Choose a base branch
from
Asintotoo:feat/decode-to-map
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenspapenhagen
requested changes
Nov 22, 2025
felipestanzani
requested changes
Nov 25, 2025
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| @Tag("unit") | ||
| public class JToonDecodeToMapTest { |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are lacking nesting examples. The edge cases must also be considered.
Collaborator
|
Could you make your review, @jenspapenhagen? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
decodeToMapmethod as a wrapper arounddecode(String)anddecode(String, DecodeOptions)that directly parses a string into a Map<String, Object>. No manual casting is required. If the result is null or invalid, an empty map is returned.Type of Change
Related Issues
Closes #
Changes Made
JToon.decodeToMap(String, DecodeOptions)methodJToon.decodeToMap(String)methodSPEC Compliance
Testing
Test Output
# Paste test output hereCode Quality
./gradlew test- all tests pass./gradlew jacocoTestCoverageVerification- coverage meets 85% thresholdChecklist
Performance Impact
Breaking Changes
Screenshots / Examples
Output:
Additional Context
Checklist for Reviewers