Skip to content

Conversation

@metalshark
Copy link
Contributor

Description

Section 13.4 Key Folding and Path Expansion
Encoder: Key Folding
Chain stops at first multi-key object
These examples however do not stop chaining at the first multi-key object.

Type of Change

  • 📝 Clarification (typo fix, grammar improvement, clarifying language)
  • 📚 Documentation (adding examples, improving structure)
  • ✨ Minor change (backward-compatible addition or clarification)
  • 🔥 Major change (breaking change, new syntax, conformance requirement change)
  • 🧪 Test fixtures (adding or updating test cases)
  • 🔧 Other (please describe):

Motivation and Context

This changes examples to comply with the specification.

Changes Made

Fixed chaining and indentation.

Specification Sections Affected

  • Section 13.4 Key Folding and Path Expansion

Backward Compatibility

  • ✅ Fully backward-compatible (no breaking changes)
  • ⚠️ Potentially breaking (requires careful review)
  • 💥 Breaking change (requires major version bump)

Impact on Existing Implementations

  • Any implementations that used the examples as test fixtures will need updated.

Test Coverage

  • Existing test fixtures pass
  • New test fixtures added (if applicable)
  • Examples in SPEC.md updated
  • Reference implementation behavior documented

Documentation

  • SPEC.md updated
  • CHANGELOG.md updated
  • Examples updated (if applicable)
  • README.md updated (if applicable)
  • Test fixtures updated (if applicable)

Checklist

  • I have read CONTRIBUTING.md
  • I have searched for similar PRs and issues
  • My changes follow the specification writing style guidelines
  • I have used RFC 2119 keywords (MUST, SHOULD, MAY) correctly where applicable
  • I have provided clear examples
  • I have updated CHANGELOG.md with my changes
  • I have considered the impact on existing implementations
  • For breaking changes: I have provided a migration strategy
  • All new and existing tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant