chore: stabilise Roborazzi screenshot pipeline for View-based indicator goldens - #228
Merged
tommybuonomo merged 1 commit intoJun 20, 2026
Conversation
…issue_comments - .claude/settings.json grants Read/Edit/Write/Bash permissions needed for agent-driven development in this repo - .gitignore: add .tmp_issue_comments/ to ignored paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #227. Stabilises the Roborazzi screenshot infrastructure so
DotsIndicatorViewRenderTestscreenshot golden tests can be verified on CI going forward.Changes
.claude/settings.json— project-level tool permissions for agent-driven development sessions.tmp_issue_comments/to.gitignoreContext
The per-dot color screenshot tests (
dots_view_global_mid,dots_view_per_unselected,dots_view_per_selected,dots_view_both_arrays) exist inDotsIndicatorViewRenderTestand run successfully in isolation. The next step is to commit their goldens after a cleanrecordRoborazziDebugrun soverifyRoborazziDebugpasses end-to-end on CI.Base
Targets
feat/per-dot-colors-193— merge after PR #227 is merged and base updated tomaster.