fix: maintain controlled pane sizes on container resize#869
Merged
Conversation
When using controlled mode with pixel sizes, panes were incorrectly being scaled proportionally when the container/window resized. This fix checks for controlled size props in handleContainerSizeChange and uses calculateInitialSizes instead of distributeSizes to maintain the fixed sizes from props. - Add hasControlledSizes check in handleContainerSizeChange - Use calculateInitialSizes for controlled panes on resize - Keep proportional distribution for uncontrolled panes - Add tests for container resize behavior - Extend test setup to support triggering resize events Fixes #868
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #868
When using controlled mode with pixel sizes, panes were incorrectly being scaled proportionally when the container/window resized. This fix checks for controlled size props in
handleContainerSizeChangeand usescalculateInitialSizesinstead ofdistributeSizesto maintain the fixed sizes from props.Changes
hasControlledSizescheck inhandleContainerSizeChangecalculateInitialSizesfor controlled panes on resize (maintains fixed pixel sizes)Root Cause
In
SplitPane.tsx,handleContainerSizeChangeunconditionally calleddistributeSizes()when the container resized, ignoring controlledsizeprops. While there was a sync effect that attempted to restore controlled sizes, it:Test Plan
npm test- all tests passnpm run lint- no errorsnpm run typecheck- no errorsnpm run build- builds successfully