fix: sync controlled pane sizes when props change#862
Merged
Conversation
Fixes #861 When using SplitPane in controlled mode with `size` props on Pane components, resetting the sizes (e.g., via a "Reset" button) did not update the UI. The internal `paneSizes` state was not syncing with the controlled `size` props after changes. Added an effect to sync `paneSizes` with controlled size props when they change, ensuring the UI reflects parent state updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #861
When using SplitPane in controlled mode with
sizeprops on Pane components, resetting the sizes (e.g., via a "Reset" button) did not update the UI. The internalpaneSizesstate was not syncing with the controlledsizeprops after changes.paneSizeswith controlled size props when they changeTest plan
npm run checkspasses (typecheck, lint, format, test)