feat: enhance session sharing and commenting with sharer information#1
Merged
feat: enhance session sharing and commenting with sharer information#1
Conversation
- Added `sharer_id` and `sharer_name` fields to the session sharing request and comment addition request for better tracking of the original sharer. - Updated the `SessionSharingService` to utilize these new fields when forwarding requests to the leader. - Improved identity handling in the HTTP handler to prioritize sharer information during session sharing and comment addition. - Enhanced integration tests to validate the correct handling of sharer information in session sharing and commenting scenarios.
- Updated `.mockery.yaml` to specify filename format for generated mocks. - Replaced custom mock implementation in `sync_service_test.go` with mockery-generated mocks for `TeamServiceInterface`. - Removed outdated mock service code to streamline test setup and improve maintainability. - Enhanced test cases to utilize mockery's capabilities for better assertion and expectation handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sharer_idandsharer_namefields to the session sharing request and comment addition request for better tracking of the original sharer.SessionSharingServiceto utilize these new fields when forwarding requests to the leader.