Fix rewirer of mod savedata being put with bad key into dictionary#8
Open
BlastSlimey wants to merge 5 commits into
Open
Fix rewirer of mod savedata being put with bad key into dictionary#8BlastSlimey wants to merge 5 commits into
BlastSlimey wants to merge 5 commits into
Conversation
lorenzofman-tobspr
approved these changes
Jun 4, 2026
lorenzofman-tobspr
requested changes
Jun 4, 2026
lorenzofman-tobspr
left a comment
lorenzofman-tobspr
left a comment
Collaborator
There was a problem hiding this comment.
Could you rebase to the latest develop branch and resolve the conflicts?
Contributor
Author
|
I synced the fork in GitHub, which is now said to be based on the develop branch. Does this suffice? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModSaveDataExtensions.AttachSaveData<T>(...)constructs the keyfullname, which is used for putting theActiveRewirerinto theModSaveDataExtensions.Rewirersdictionary, with an extra.json. That crashes the game wheneverModSaveDataExtensions.GetRewirer<T>(...)is called (and also saves the mod's savedata into a file with double extension).While looking at it, I also noticed that the
ModSaveDataRewirerconstructor tries to correct a potential incorrect file extension, but never gets to do it because it checks for the string"json"having an extension.