fix(deps): bump better-sqlite3 to ^12.4.5 for Node 25 support#341
Open
JasonOA888 wants to merge 1 commit intotobi:mainfrom
Open
fix(deps): bump better-sqlite3 to ^12.4.5 for Node 25 support#341JasonOA888 wants to merge 1 commit intotobi:mainfrom
JasonOA888 wants to merge 1 commit intotobi:mainfrom
Conversation
better-sqlite3@11.x has no prebuilt binaries for Node 25 and fails source compilation due to V8 API changes in Node 25. better-sqlite3@12.4.5 added Node 25 support (prebuilds + engines). Fixes tobi#257
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
npm install -g @tobilu/qmdfails on Node 25 because qmd pinsbetter-sqlite3@^11.0.0, which:Solution
Bump
better-sqlite3from^11.0.0to^12.4.5.better-sqlite3 v12.4.5 added Node 25 support (prebuilds + engines) in WiseLibs/better-sqlite3#1411.
Compatibility
engines: { node: ">=22.0.0" }which includes Node 25Fixes #257