fix(cli): add runtime-aware bin wrapper for bun/node compatibility#340
Open
JasonOA888 wants to merge 1 commit intotobi:mainfrom
Open
fix(cli): add runtime-aware bin wrapper for bun/node compatibility#340JasonOA888 wants to merge 1 commit intotobi:mainfrom
JasonOA888 wants to merge 1 commit intotobi:mainfrom
Conversation
When qmd is installed via `bun install -g`, better-sqlite3 is compiled against bun's ABI. But the shebang `#!/usr/bin/env node` runs it with node, causing ABI mismatch errors. Solution: - Add bin/qmd shell wrapper that detects install runtime - Use bun if bun.lock exists or BUN_INSTALL is set - Fall back to node otherwise - Update package.json bin entry to use wrapper This allows both `bun install -g` and `npm install -g` to work correctly. Fixes tobi#319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Installing qmd via
bun install -g @tobilu/qmdcompiles native modules (better-sqlite3) against bun's internal ABI. But the CLI shebang#!/usr/bin/env noderuns it with the system Node.js, causing:Solution
Add a shell wrapper (
bin/qmd) that detects the install runtime:bun.lock/bun.lockbin package directoryBUN_INSTALLenvironment variablebunto run the CLInodeThis ensures native modules run with the same runtime they were compiled for.
Changes
bin/qmdshell wrapper with runtime detectionpackage.jsonbin entry to use wrapperbin/to files arrayFixes #319