fix(embed): skip oversized chunks instead of crashing#339
Open
JasonOA888 wants to merge 1 commit intotobi:mainfrom
Open
fix(embed): skip oversized chunks instead of crashing#339JasonOA888 wants to merge 1 commit intotobi:mainfrom
JasonOA888 wants to merge 1 commit intotobi:mainfrom
Conversation
When first chunk exceeds embedding model context window (e.g., 2048 tokens for EmbeddingGemma), qmd embed crashes with unhandled error. Changes: - Try embedding chunks sequentially until one succeeds to get dimensions - Log warning for skipped chunks that fail embedding - Only throw error if ALL chunks fail (not just first) - Prevents SIGABRT on Apple Silicon from GGML Metal cleanup assertion Fixes tobi#303
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
qmd embedcrashes when the first chunk exceeds the embedding model context window (2048 tokens for EmbeddingGemma-300M):On Apple Silicon, this can also trigger a GGML Metal cleanup assertion resulting in SIGABRT.
Solution
Instead of failing on the first chunk, try embedding chunks sequentially until one succeeds:
Behavior Changes
Fixes #303