fix(mcp): support Windows HOME and enable production mode#334
Open
JasonOA888 wants to merge 1 commit intotobi:mainfrom
Open
fix(mcp): support Windows HOME and enable production mode#334JasonOA888 wants to merge 1 commit intotobi:mainfrom
JasonOA888 wants to merge 1 commit intotobi:mainfrom
Conversation
Two bugs prevented MCP server from finding the database on Windows: 1. store.ts: HOME fallback only checked process.env.HOME, which is undefined on Windows (uses USERPROFILE instead). Added fallback: process.env.HOME || process.env.USERPROFILE || "/tmp" 2. mcp.ts: startMcpServer() and startMcpHttpServer() did not call enableProductionMode() before createStore(), causing database path to resolve incorrectly. Fixes tobi#277
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MCP server returns 0 documents on Windows even though CLI works correctly.
Root Cause
Two bugs:
store.ts:46 -
HOMEfallback only checksprocess.env.HOME, which is undefined on Windows (usesUSERPROFILE). This causes database path to resolve to/tmp/.cache/qmd/index.sqliteinstead of the correct Windows path.mcp.ts -
startMcpServer()andstartMcpHttpServer()do not callenableProductionMode()beforecreateStore(), causing the production database path to not be properly initialized.Solution
process.env.HOME || process.env.USERPROFILE || "/tmp"enableProductionMode()call in both MCP server functions beforecreateStore()Testing
Fixes #277