Skip to content

fix(embed): display actual model name from QMD_EMBED_MODEL env var#332

Open
JasonOA888 wants to merge 1 commit intotobi:mainfrom
JasonOA888:fix/embed-model-display
Open

fix(embed): display actual model name from QMD_EMBED_MODEL env var#332
JasonOA888 wants to merge 1 commit intotobi:mainfrom
JasonOA888:fix/embed-model-display

Conversation

@JasonOA888
Copy link

Problem

When using QMD_EMBED_MODEL to switch to a different embedding model, qmd embed still displays Model: embeddinggemma even though the correct model is downloaded and used.

export QMD_EMBED_MODEL="hf:Qwen/Qwen3-Embedding-0.6B-GGUF/Qwen3-Embedding-0.6B-Q8_0.gguf"
qmd embed -f
# Output: Model: embeddinggemma  <-- incorrect

Root Cause

Two different DEFAULT_EMBED_MODEL constants exist:

  • store.ts:47 - hardcoded display label "embeddinggemma"
  • llm.ts:196 - actual model URI (respects QMD_EMBED_MODEL env var)

qmd.ts was importing and using the wrong constant for display.

Solution

  1. Add extractModelDisplayName() helper to extract readable name from model URI
  2. Use DEFAULT_EMBED_MODEL_URI (llm.ts) instead of DEFAULT_EMBED_MODEL (store.ts)
  3. Apply extractModelDisplayName() when printing the model name

Result

Now correctly shows:

Model: embeddinggemma-300M-Q8_0      # for default model
Model: Qwen3-Embedding-0.6B-Q8_0     # for custom models

Fixes #328

Previously, 'qmd embed' always displayed 'Model: embeddinggemma'
even when using a custom model via QMD_EMBED_MODEL env var.

Root cause: store.ts exports DEFAULT_EMBED_MODEL as a hardcoded
display label, while llm.ts uses DEFAULT_EMBED_MODEL_URI for the
actual model path. qmd.ts was using the wrong constant.

Changes:
- Add extractModelDisplayName() helper to extract readable name from URI
- Change vectorIndex(), vectorSearch(), querySearch() to use
  DEFAULT_EMBED_MODEL_URI instead of store's DEFAULT_EMBED_MODEL
- Apply extractModelDisplayName() when printing the model name

Now correctly shows:
- 'embeddinggemma-300M-Q8_0' for default model
- 'Qwen3-Embedding-0.6B-Q8_0' for custom models

Fixes tobi#328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

qmd embed displays hardcoded 'Model: embeddinggemma' when using QMD_EMBED_MODEL

1 participant