perf: skip unchanged files via mtime checks and wrap inserts in transaction#324
Open
perf: skip unchanged files via mtime checks and wrap inserts in transaction#324
Conversation
…ansaction management - Introduced a mechanism to skip reading files if their modification time (mtime) hasn't changed, reducing unnecessary file reads. - Wrapped all database inserts/updates in a single transaction to improve performance. - Updated the `findActiveDocument` function to include the `modified_at` field in the returned document structure. - Enhanced logging to indicate the number of files skipped due to unchanged mtime. These changes optimize the indexing process and improve overall efficiency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mtimehasn't changed since last index, reducing unnecessary disk I/OfindActiveDocumentto includemodified_atin returned structureNo functional changes — pure performance improvement to the indexing path.
Test plan
qmd indexon a large directory, verify files with unchanged mtime are skipped on subsequent runs🤖 AI-assisted (Claude) | Tested on local instance with ~265k file corpus