feat: use build: "autoAttempt" on getLlama#310
Merged
Conversation
Owner
|
Thank you so much! really appreciate it @giladgd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build: "autoAttempt"works similarly to the current behavior inqmdbut is more efficient, faster, and allows the use ofNODE_LLAMA_CPP_GPUenv var to customize the defaultgpuused ingetLlamawhen it's unset.It should fix most of the issues users experience with CUDA not loading since
node-llama-cpp's internal backend resolution flow is more detailed and handles many edge cases.It should also fix issues where CUDA is attempted to be used despite the system not supporting it (the current code doesn’t pass the required parameter to
getLlamaGpuTypeswhich is undefined behavior).Fixes #307
Fixes #287
Fixes #268
Resolves #293
Resolves #266
Resolves #250
Resolves #246
Resolves #243
Resolves #240
Resolves #237
Partially remedies #222
Fixes #213
Fixes #194
Fixes #185
Fixes #87 (the new
node-llama-cppversion properly detectsglibcon nixos now)Fixes #59 (the new
node-llama-cppversion contains a workaround for this bug in Bun)