don't recreate the player for video changes#397
Open
iyzana wants to merge 1 commit intotjallingt:canaryfrom
Open
don't recreate the player for video changes#397iyzana wants to merge 1 commit intotjallingt:canaryfrom
iyzana wants to merge 1 commit intotjallingt:canaryfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ea68cdc:
|
iyzana
changed the title
iyzana
changed the title
Author
|
In the codesandbox the change can be seen when clicking "Change video". Without this change the player fades to white for a bit, with this change only the video itself is updated which is quite a bit faster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure why the player is being reset when the videoId changes. That case is already handled by
shouldUpdateVideoas far as I can tell. I tested my change in Firefox and Google Chrome and switching the video still works as expected.The check has been introduced in #284 but I did not find any reason for it there.
Without this change the player automatically leaves fullscreen on video changes which is undesirable for me.
Additionally to that, fullscreen can't then be resumed in Google Chrome, because the youtube player believes it is still fullscreened (iyzana/vsync#53).