perf(github): cache compare API results to reduce redundant calls#15
Open
erickzhao wants to merge 1 commit into
Open
perf(github): cache compare API results to reduce redundant calls#15erickzhao wants to merge 1 commit into
erickzhao wants to merge 1 commit into
Conversation
The GitHub versioner's getMergeBase, isAncestor, getDistance, and getBranchForCommit all call compareCommitsWithBasehead independently, discarding each other's results. This adds a per-instance cache keyed on the basehead string so identical compare pairs are only fetched once. Also hoists an invariant getMergeBase call out of the loop in getNearestReleaseBranchForSHA (benefits both Local and GitHub versioners). Measured on the test fixture: 87 → 80 compare API calls (-8%), with savings scaling proportionally to the number of release branches. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compareCommitsWithBaseheadresults inGitHubVersioner, keyed on thebaseheadstring.getMergeBase,isAncestor,getDistance, andgetBranchForCommitnow go through a sharedgetCompareResultmethod that deduplicates identical API calls.getMergeBase(defaultBranch, sha)call out of the loop ingetNearestReleaseBranchForSHA(in the base class, so bothLocalVersionerandGitHubVersionerbenefit).Performance
Measured against the test fixture (
erickzhao/desktop-test-fixture):Savings scale with the number of release branches. The biggest wins come from:
getBranchForCommitcalled twice — second is a full cache hit)Test plan
🤖 Generated with Claude Code