add Digital Motion Processor for MPU6050 - see issue #733 #796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykevl
requested changes
Oct 4, 2025
There was a problem hiding this comment.
See the comments. Essentially, this needs a bit more integration into the drivers repo to be mergeable, meaning the PR should modify the existing mpu6050 driver instead of creating a whole new driver from scratch that duplicates functionality with the existing driver.
There was a problem hiding this comment.
If this is an example, it should be in examples/mpu6050.
There was a problem hiding this comment.
Please don't include files like these.
There was a problem hiding this comment.
I don't think Python examples belong in the drivers repo.
There was a problem hiding this comment.
You are essentially recreating the MPU6050 driver here. I really don't want to see two drivers for the same hardware. So my suggestion would be to integrate the DMP changes you made into the existing MPU6050 driver, instead of adding a new driver.
|
Hi Ayke,
Yea I figured that much, hence my initial email.
Sorry about the .DSstore - i thought I killed it..
With regards to the topology I will have to think it through and give it a
try. In my repo the code is obviously coupled close to the application and
purpose. The tinygo driver layout is more of a challenge to me and I need
to apply some refactoring. I do agree with the example stuff - it was my
initial concern - but the only way to context with the original Youtube
explanation. Theory is important, you know...
I will have a go at it later when I manage to wrap my mind around the
structure and merger and still keep the context intact. Nevertheless, I get
the gist of it.
If you have more ideas, I am all ears. I will get back to you.
B
…On Sat, 4 Oct 2025 at 11:25, Ayke ***@***.***> wrote:
***@***.**** requested changes on this pull request.
See the comments. Essentially, this needs a bit more integration into the
drivers repo to be mergeable, meaning the PR should modify the existing
mpu6050 driver instead of creating a whole new driver from scratch that
duplicates functionality with the existing driver.
------------------------------
On mpu6050/digital_motion_processor/main.go
<#796 (comment)>:
If this is an example, it should be in examples/mpu6050.
------------------------------
On mpu6050/digital_motion_processor/python-animation/.DS_Store
<#796 (comment)>:
Please don't include files like these.
------------------------------
On mpu6050/digital_motion_processor/python-animation/Animation.py
<#796 (comment)>:
I don't think Python examples belong in the drivers repo.
------------------------------
On mpu6050/digital_motion_processor/mpu6050/DMP.go
<#796 (comment)>:
You are essentially recreating the MPU6050 driver here. I really don't
want to see two drivers for the same hardware. So my suggestion would be to
integrate the DMP changes you made into the existing MPU6050 driver,
instead of adding a new driver.
—
Reply to this email directly, view it on GitHub
<#796 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABN6M5S3NZUQQDS6DB5NN5T3V6G6ZAVCNFSM6AAAAACIEPTNASVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGMBRG4YDMNRSGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the MPU6050 go drivers with Digital Motion Processing functionality. This version does not have a gimble lock.
See issue 733: Please submit a Pull Request.