Skip to content

svelte-apollo does not respect error policies #123

Description

@ritchieanesco

Svelte apollo does not seem to correctly handle the error policies. See here

Looking at the code:
https://github.com/timhall/svelte-apollo/blob/master/packages/svelte-apollo/src/observable.ts#L58-L63

Below is pseudo code proposing checks for the different policies:

  if (result.errors) {

    let error = new ApolloError({ graphQLErrors: result.errors });
    if ( errorPolicy === "all") {

      set({ loading: false, data: results.data, error });

    } else if ( errorPolicy === "ignore") {

      error = new ApolloError({ clientErrors: result.errors });
      set({ loading: false, data: results.data, error });

    } else {

      // "none": default policy
      set({ loading: false, data: undefined, error });
    }
    
  } else {
    set({ loading: false, data: result.data, error: undefined });
  }

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions