tests: guard pk3 native library cache#214
Draft
cursor[bot] wants to merge 5 commits into
Draft
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
Co-authored-by: Tim Fox <timfox@outlook.com>
Co-authored-by: Tim Fox <timfox@outlook.com>
Co-authored-by: Tim Fox <timfox@outlook.com>
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_pk3_native_library_cachescript coverage for pk3-backed native module extraction/cache behavior insrc/qcommon/files.c.tests/README.md.Risky behavior now covered
com_nativeLibraryExtractPk3remains default-on, archived, described, and logged at filesystem startup.vm/native_cache/path underfs_homepath/fs_gamedir.vm/, andmodules/pk3 probes stay in order, cache reuse remains gated by length + CRC, andFS_LoadLibrarychecks the pk3 cache before loose filesystem paths.Test files added/updated
tests/scripts/test_pk3_native_library_cache.sh.CMakeLists.txtto registertest_pk3_native_library_cache.tests/README.mdwith the new script test.Why this reduces regression risk
This path touches native code loading and writable cache files. The test protects extension filtering, cache path construction, fallback ordering, and CRC validation without requiring game data or executing platform native loaders.
Validation
tests/scripts/test_pk3_native_library_cache.shcmake -S . -B build-coverage-tests -DBUILD_TESTING=ON -DBUILD_UNIT_TESTS=OFFctest --test-dir build-coverage-tests -R test_pk3_native_library_cache --output-on-failure