Remove obsolete SKIP_IDPAK_CHECK build flag#206
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
FS_CheckIdPaks was already removed; the ifdef only wrapped a no-op. Drop the compile definition, script/CI/Android preset wiring, and update docs that referenced the flag. Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
SKIP_IDPAK_CHECKCMake option and all associated wiring. The only runtime behavior it gated was a no-op left afterFS_CheckIdPakswas removed (FS_Startupcontained an emptyifwith a commented-out call).Flags removed
SKIP_IDPAK_CHECK(CMakeOPTION, compile definition, presets, Android Gradle, CI env/cmake args)#ifndefblock infiles.c.compile_engine.sh:skip-idpak-check/skip-paksarguments-DSKIP_IDPAK_CHECK=ON; CMake already defaulted to skipping the (removed) check path in practice.Why this is safe
SKIP_IDPAK_CHECK, which excluded the#ifndefblock entirely. The#elsebranch only ran twoFS_IsBaseGamechecks with an empty body—no pak validation.Behavioral parity checks
./scripts/compile_engine.sh vulkan(Release configure + build): passedctest --output-on-failure -Vfrombuild-vk-Release(26 tests includingsmoke_test, renderer regression scripts, units): passedDocs
Updated references in
BUILD.md,AGENTS.md,docs/DEVELOPMENT_SETUP.md,docs/ARM_RASPBERRY_PI.md, anddocs/RENDERER_CONFIDENCE.mdso copy-paste CMake examples no longer mention the removed flag.