Skip to content

Remove obsolete SKIP_IDPAK_CHECK build flag#206

Draft
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/stale-feature-flag-cleanup-906a
Draft

Remove obsolete SKIP_IDPAK_CHECK build flag#206
cursor[bot] wants to merge 1 commit into
mainfrom
cursor/stale-feature-flag-cleanup-906a

Conversation

@cursor
Copy link
Copy Markdown

@cursor cursor Bot commented May 11, 2026

Summary

Removes the SKIP_IDPAK_CHECK CMake option and all associated wiring. The only runtime behavior it gated was a no-op left after FS_CheckIdPaks was removed (FS_Startup contained an empty if with a commented-out call).

Flags removed

Flag / plumbing Notes
SKIP_IDPAK_CHECK (CMake OPTION, compile definition, presets, Android Gradle, CI env/cmake args) No remaining C preprocessor uses after deleting the dead #ifndef block in files.c.
compile_engine.sh: skip-idpak-check / skip-paks arguments These only forwarded -DSKIP_IDPAK_CHECK=ON; CMake already defaulted to skipping the (removed) check path in practice.

Why this is safe

  • Active vs rolled-out path: Default CI/script builds already defined SKIP_IDPAK_CHECK, which excluded the #ifndef block entirely. The #else branch only ran two FS_IsBaseGame checks with an empty body—no pak validation.
  • No functional regression: Filesystem init, pak loading, and dedicated-server startup are unchanged; only dead preprocessor/script noise is removed.

Behavioral parity checks

  • ./scripts/compile_engine.sh vulkan (Release configure + build): passed
  • ctest --output-on-failure -V from build-vk-Release (26 tests including smoke_test, renderer regression scripts, units): passed

Docs

Updated references in BUILD.md, AGENTS.md, docs/DEVELOPMENT_SETUP.md, docs/ARM_RASPBERRY_PI.md, and docs/RENDERER_CONFIDENCE.md so copy-paste CMake examples no longer mention the removed flag.

Open in Web View Automation 

FS_CheckIdPaks was already removed; the ifdef only wrapped a no-op. Drop the
compile definition, script/CI/Android preset wiring, and update docs that
referenced the flag.

Co-authored-by: Tim Fox <timfox@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant