[BugFix] Add float4 definitions to cpp/common.h for CPU backend#1902
[BugFix] Add float4 definitions to cpp/common.h for CPU backend#1902ShaobinChen-AH wants to merge 1 commit intotile-ai:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIntroduces a cross-language Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
👋 Hi! Thank you for contributing to the TileLang project. Please remember to run We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀 |
|
Repeated: #1901 |
Problem
When compiling CPU kernels that use
T.copy, the generated code referencesfloat4type which is not defined, causing compilation errors:Root Cause
The CPU backend uses
tl_templates/cpp/common.hwhich lacked float4 definitions. CUDA backend doesn't need this because float4 is built into CUDA SDK.Fix
float4struct definition tosrc/tl_templates/cpp/common.hmake_float4helper functionTesting