Operator changes for v3 CRD mode #4092
Open
+6,287
−3,276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 60 days with no activity. |
caseydavenport
force-pushed
the
casey-v3-crds
branch
from
69e9345 to
b1de2b0
Compare
caseydavenport
changed the title
caseydavenport
commented
Jan 23, 2026
caseydavenport
commented
Jan 23, 2026
caseydavenport
commented
Jan 23, 2026
caseydavenport
commented
Jan 23, 2026
| Rules: []rbacv1.PolicyRule{ | ||
| { | ||
| APIGroups: []string{"crd.projectcalico.org"}, | ||
| APIGroups: []string{ |
Member
Author
There was a problem hiding this comment.
Components now need access to both API groups.
caseydavenport
commented
Jan 23, 2026
| Resources: []string{ | ||
| // Pools are watched to maintain a mapping of blocks to IP pools, and for finalization. | ||
| "ippools", | ||
| // NetworkPolicies are watched for defaulting. |
Member
Author
There was a problem hiding this comment.
New permissions for new controllers added in the linked PR
caseydavenport
commented
Jan 23, 2026
caseydavenport
commented
Jan 23, 2026
| if c.cfg.Installation.CalicoNetwork.LinuxPolicySetupTimeoutSeconds != nil { | ||
| linuxPolicySetupTimeoutSeconds = *c.cfg.Installation.CalicoNetwork.LinuxPolicySetupTimeoutSeconds | ||
| } | ||
| apiGroup := "" |
Member
Author
There was a problem hiding this comment.
Changes to configure the CNI plugin with the correct API group to use
caseydavenport
force-pushed
the
casey-v3-crds
branch
from
b1de2b0 to
7f0fad3
Compare
caseydavenport
force-pushed
the
casey-v3-crds
branch
from
7f0fad3 to
1ee85b1
Compare
caseydavenport
commented
Jan 23, 2026
| } | ||
|
|
||
| // add adds watches for resources that are available at startup | ||
| func add(c ctrlruntime.Controller, r *ReconcileInstallation) error { |
Member
Author
There was a problem hiding this comment.
I combined add() into Add() because there's not really a reason to split them, and I needed access to opts within this function.
caseydavenport
force-pushed
the
casey-v3-crds
branch
3 times, most recently
from
e02dde2 to
af13b7f
Compare
caseydavenport
force-pushed
the
casey-v3-crds
branch
7 times, most recently
from
506d787 to
7a71032
Compare
caseydavenport
force-pushed
the
casey-v3-crds
branch
from
7a71032 to
5deb9f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To support projectcalico/calico#10447
calico_api_groupto the CNI plugin so it knows which API to use.Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.