fix overflow bug #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this happening on 32-bit only platforms? I don't see an issue with 64-bit platforms. |
hselasky
reviewed
Oct 13, 2021
| if ( !mMode_Time ) { | ||
| mSettings->mAmount -= currLen; | ||
| if (mSettings->mAmount >= currLen) { | ||
| mSettings->mAmount -= currLen; |
There was a problem hiding this comment.
Please fix indention style here.
Also, mAmount should only be compared for zero, because it is unsigned!
0 >= mSettings->mAmount
Should probably be:
0 == mSettings->mAmount
|
I see now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original program does not work with parameter -n.
Note the mSettings->mAmount is an unsigned type. We need to take care of the case when mSettings->mAmount - currLen leads to overflow.