Use explicit namespace qualification in tally_n()
#7768
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use explicit namespace qualification (
dplyr::n()andbase::sum()) instead of bare function names in quosure expressions to satisfy duckplyr's function identity checks.Changes
expr(n())toexpr(dplyr::n())in the null weight caseexpr(sum(!!wt, na.rm = TRUE))toexpr(base::sum(!!wt, na.rm = TRUE))in the weighted casebaseenv()back toquo_get_env(wt)for weighted case since explicit qualification makes environment less criticalThis approach is cleaner than using quosures with specific environments because the namespace qualification is directly in the expression.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.