Repository navigation
Release Candidate 1.2.0 - #444
Merged
Merged
Conversation
The 1.2.0 win-builder submission flagged "Overall checktime > 10 min" on Windows. Evaluating a boosted C5.0 tidypredict expression scales sharply with trial count, and the regression test for #287 fit 18 boosted models (6 seeds x 3 trial counts) to exercise it, accounting for 45% of the local test suite runtime. Seeds 1 and 6 each independently reproduce the original regression at every trial count, so the other four are dropped. Also cut the boost_tree()/C5.0 parsnip integration test from trees = 10 to trees = 3, since it only checks the integration plumbing, not the voting-confidence edge case.
xrf::xrf()'s deoverlap merging cost grows sharply with rule count, and xrf_reg_model()'s default xgb_control (nrounds = 5, max_depth = 3) generates far more rules than needed here, making this the second-slowest test in the suite behind the C5.0 boosting fix. A shallower control still produces multiple rules to deoverlap and predictions still match predict(), so this calls xrf::xrf() directly with nrounds = 3, max_depth = 2 instead of going through the shared helper (which 11 other tests rely on with its default).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to close #443