Repository navigation
Clear the outstanding R CMD check and roxygen2 warnings - #442
Merged
Merged
Conversation
roxygen2 warned that each method needed an @export or @exportS3Method tag. The generic stays internal, so @exportS3Method registers the methods without exporting them.
catboost is not on CRAN and has no CRAN-style repository to declare in Additional_repositories, so shipping the vignette left R CMD check with an unstated vignette dependency NOTE. The article still builds to the same URL on the website.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devtools::document()was warning that the elevenbuild_tree_formula()methods needed registration, anddevtools::check()reported a NOTE for the undeclaredcatboostdependency in the vignettes, which arrived with the CatBoost support in #179. Registering the methods with@exportS3Methodkeeps the generic internal, and moving the CatBoost vignette tovignettes/articles/is the usual way to document a package that cannot be declared inSuggests(catboost is not on CRAN and has no CRAN-style repository to pointAdditional_repositoriesat). The article still builds to the same website URL, so the existing cross-references are unaffected.devtools::check()is now clean: 0 errors, 0 warnings, 0 notes.