[WEB-4330] - Missing Pump Settings in PDF #587
Merged
+56
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henry-tp
changed the title
henry-tp
commented
Jan 26, 2026
henry-tp
commented
Jan 26, 2026
src/utils/DataUtil.js
Outdated
| } else { | ||
| // Clock drift on user's device may cause pumpSettings datum to have LATER timestamp than upload | ||
| // datum. The maximum time devation that Uploader allows between user device and tidepool server | ||
| // time is 15 minutes, so we search 15 minutes into the future for the pumpSettings datum |
Contributor
Author
There was a problem hiding this comment.
Please examine this comment for interpretable-ness .. I struggled to phrase this in a summarized but still comprehensible way
Member
There was a problem hiding this comment.
@henry-tp I'm fine with the comment content. Copilot did point out a typo that could be fixed, but I don't have any strong opinion about the phrasing.
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts pumpSettings selection for the “latest pump upload” to tolerate small clock drift, preventing missing pump settings in generated PDFs.
Changes:
- Allow selecting
pumpSettingsup to 15 minutes afterlatestPumpUpload.timefor non-continuous uploads. - Update/add unit tests to cover the >15 minute exclusion and <=15 minute inclusion behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/utils/DataUtil.js |
Relaxes pumpSettings timestamp filtering by adding a 15-minute tolerance window. |
test/utils/DataUtil.test.js |
Updates and adds tests validating pumpSettings selection with the new tolerance logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ol-org/viz into WEB-4330-missing-settings
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ol-org/viz into WEB-4330-missing-settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEB-4330
Blip: tidepool-org/blip#1853