Skip to content

Use custom Unmarshal implementation for getrawdiff #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isobelormiston merged 2 commits into from
Jun 9, 2026
Merged

Use custom Unmarshal implementation for getrawdiff #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1d3213
Use custom Unmarshal implementation for getrawdiff
isobelormiston Jun 8, 2026
6777ef4
Apply suggestion from @toastwaffle
isobelormiston Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions responses/differential_getrawdiff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,27 @@
package responses

import "github.com/thought-machine/gonduit/entities"
import (
"encoding/json"

"github.com/thought-machine/gonduit/entities"
)

// DifferentialGetRawDiffResponse is the response from calling differential.getrawdiff.
type DifferentialGetRawDiffResponse *entities.DifferentialRawDiff
type DifferentialGetRawDiffResponse struct {
*entities.DifferentialRawDiff
}

// UnmarshalJSON handles the fact that Phabricator returns the diff as a JSON-encoded string.
func (r *DifferentialGetRawDiffResponse) UnmarshalJSON(b []byte) error {
var rawString string
if err := json.Unmarshal(b, &rawString); err == nil {
r.DifferentialRawDiff = &entities.DifferentialRawDiff{
Diff: rawString,
}
return nil
}

// If it is a real JSON object, unmarshal it into the underlying struct normally.
r.DifferentialRawDiff = &entities.DifferentialRawDiff{}
return json.Unmarshal(b, r.DifferentialRawDiff)
}
Loading