CI: fix useless warnings, skip default branch when resolving dependencies. #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency resolution logic resolve_dependent_repos.py currently
tries to apply the "ganged branch" logic even for the default branch,
creating useless and misleading warnings:
* thliebig/CSXCAD: different branch "master" used
repo thliebig/CSXCAD branch master is used instead of the default branch.
* thliebig/fparser: different branch "master" used
repo thliebig/fparser branch master is used instead of the default branch.
Avoid applying "branch ganging" if the dependency is already on the
branch we're switching to.
Signed-off-by: Yifeng Li <tomli@tomli.me>
biergaizi
changed the title
The option "permissions: packages: write" was used to enable NuGet repository for vcpkg caching, but eventually this caching method was not used due to my security concerns of cache poisoning. It's unclear whether a third-party contributor can write arbitrary packages to the NuGet repository. Thus, regular GitHub file caching via "actions/cache" was used (which is isolated per branch, by default, it's not possible to overwrite the trusted "master" branch caching just by opening a PR). Remove unused "permissions: packages: write". Signed-off-by: Yifeng Li <tomli@tomli.me>
biergaizi
force-pushed
the
dependent_repos_skip
branch
from
7c01582 to
e96d9d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: skip default branch when resolving dependencies.
The dependency resolution logic resolve_dependent_repos.py currently tries to apply the "ganged branch" logic even for the default branch, creating useless and misleading warnings:
Avoid applying "branch ganging" if the dependency is already on the branch we're switching to.
CI: remove unused "permissions: packages: write"
The option
permissions: packages: writewas used to enable NuGet repository for vcpkg caching, but eventually this caching method was not used due to my security concerns of cache poisoning. It's unclear whether a third-party contributor can write arbitrary packages to the NuGet repository. Thus, regular GitHub file caching via "actions/cache" was used (which is isolated per branch, by default, it's not possible to overwrite the trusted "master" branch caching just by opening a PR).Remove unused
permissions: packages: write.