Feat/changelog filter #168
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
typecheck issues aren't from our code |
| useEffect(() => { | ||
| if (typeof window === "undefined") return | ||
|
|
||
| const changelogItems = document.querySelectorAll(".changelog-item") |
Member
There was a problem hiding this comment.
These are direct DOM style manipulations instead of React state
Author
There was a problem hiding this comment.
I think the DOM style manipulations are necessary because the only react component is the filtering piece and the rest are coming from an astro component and all the filtering is client side. We aren't loading the list of changelog items into a React component, but rendering them directly to the DOM.
markshenouda
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.Any change needs to be discussed before proceeding.
Closing issues
closes 156 from search repo
...
Description
...
Changes